Use unordered_set for whitelist lookups#21
Open
undertheironbridge wants to merge 1 commit intoOPSnet:masterfrom
Open
Use unordered_set for whitelist lookups#21undertheironbridge wants to merge 1 commit intoOPSnet:masterfrom
undertheironbridge wants to merge 1 commit intoOPSnet:masterfrom
Conversation
undertheironbridge
force-pushed
the
whitelist-in-unordered-map
branch
from
a4f6866 to
39388d6
Compare
undertheironbridge
force-pushed
the
whitelist-in-unordered-map
branch
from
39388d6 to
dc33e00
Compare
Contributor
Author
|
It just occurred to me that the database-stored whitelist entries are actually meant to be used as peer_id prefixes, not literal peer_ids to be matched. In this case, this whole PR can really be scrapped, as it won't work as expected. The only thing that can potentially stay is the test script (with appropriate changes), which might come in handy should anyone like to change the whitelisting implementation or perhaps use it as a starting point for testing the tracker as a whole. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All whitelist lookups are currently performed by a linear search over a
std::vectorofstd::stringobjects. Since peer IDs are always 20 bytes long, anstd::arraymight be better suited for this, and has the added advantage of always storing the data contiguously, which is not a requirement withstd::strings. Storing suchstd::arrays in anunordered_setgives a clear performance advantage, as illustrated in this benchmark.Since whitelist lookups need to be made for every announce, I suppose this might have a very positive impact on the overall performance of the tracker.